From 41cebdd1a6b5e880c768a4af69724851e6a06108 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Fri, 3 Apr 2020 10:57:41 +0200 Subject: [PATCH] x86/p2m: drop pointless nested variable from guest_physmap_add_entry() There's an outer scope rc already, and its use for the mem-sharing logic does not conflict with its use elsewhere in the function. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- xen/arch/x86/mm/p2m.c | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index 113456a7e9..51b9e2584d 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -902,7 +902,6 @@ guest_physmap_add_entry(struct domain *d, gfn_t gfn, mfn_t mfn, if ( p2m_is_shared(ot) ) { /* Do an unshare to cleanly take care of all corner cases. */ - int rc; rc = mem_sharing_unshare_page(p2m->domain, gfn_x(gfn_add(gfn, i))); if ( rc ) { -- 2.30.2